fix level-loading crashes #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When new levels are loaded the Hull and Level/Set menus are re-created from scratch. This would leave dangling pointers in nanogui::Screen (mDragWidget and mFocusPath). The "best" fix would probably be to replace all Widget pointers with shared_ptr<Widget>. But this is a quick fix that gets the job done. I also added "/dbg rload X" which will load a new level every X seconds. This was useful for recreating this bug but also might be useful for discovering other random level-load issues in the future so I left it in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When new levels are loaded the Hull and Level/Set menus are re-created from scratch. This would leave dangling pointers in
nanogui::Screen(mDragWidgetandmFocusPath). The "best" fix would probably be to replace allWidgetpointers withshared_ptr<Widget>. But this is a quick fix that gets the job done.I also added
/dbg rload Xwhich will load a new level every X seconds. This was useful for recreating this bug but also might be useful for discovering other random level-load issues in the future so I left it in.